Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #683 #721

Merged
merged 5 commits into from
Apr 15, 2020
Merged

resolves #683 #721

merged 5 commits into from
Apr 15, 2020

Conversation

gdoerr
Copy link
Contributor

@gdoerr gdoerr commented Apr 14, 2020 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Custom webpack configuration functions are not able to access the target and therefore are not able to vary their behavior base on the invoked build.

What is the new behavior?

Passes TargetOptions to the Custom Webpack Config function per Issue @683

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

just-jeb
just-jeb requested changes Apr 15, 2020
View reviewed changes
Copy link
Owner

@just-jeb just-jeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thank you very much for your contribution! I had just one comment, please address it and I'll merge.

@just-jeb
Copy link
Owner

@all-contributors please add @gdoerr for code.

@allcontributors allcontributors bot mentioned this pull request Apr 15, 2020
Merged
@allcontributors
Copy link
Contributor

@just-jeb

I've put up a pull request to add @gdoerr! 🎉

@just-jeb just-jeb merged commit 7a44528 into just-jeb:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@just-jeb just-jeb just-jeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdoerr @just-jeb